Skip to content

Conversation

@pjdavis
Copy link

@pjdavis pjdavis commented Feb 22, 2019

Given a date range of the format "%d %b %Y to %d %b %Y" such as "01 Jan 1988 to 31 Dec 1999" chronic will throw the error NoMethodError (undefined method '+' for nil:NilClass). This happens because getting the anchor won't work for some weirder date formats and just returns nil, that in turn gets passed to the offset method.

It looks like it could probably happen with other repeaters as well, but I was unable to craft a string of sufficient silliness to cause it to happen in other repeaters.

Now, instead of throwing an error, Chronic.parse will just return nil, which is consistent with the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant