Skip to content

Version agnostic dict encoding fix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
woahdae wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Version agnostic dict encoding fix #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bert.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ encode_term(Term) ->
[] -> {bert, nil};
true -> {bert, true};
false -> {bert, false};
Dict when is_record(Term, dict, 8) ->
Dict when is_tuple(Term) andalso element(1, Term) =:= dict ->
{bert, dict, dict:to_list(Dict)};
List when is_list(Term) ->
lists:map((fun encode_term/1), List);
Expand Down
14 changes: 13 additions & 1 deletion test/bert_test.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ encode_tuple_nesting_test() ->
Bert = term_to_binary({foo, {bert, true}}),
Bert = encode({foo, true}).

encode_dict_test() ->
Bert = term_to_binary({ bert, dict,
dict:to_list(dict:store(foo, true, dict:new())) }),
Bert = encode(dict:store(foo, true, dict:new())).

%% decode

decode_list_nesting_test() ->
Expand All @@ -20,4 +25,11 @@ decode_list_nesting_test() ->
decode_tuple_nesting_test() ->
Bert = term_to_binary({foo, {bert, true}}),
Term = {foo, true},
Term = decode(Bert).
Term = decode(Bert).

decode_dict_test() ->
Bert = term_to_binary({ bert, dict,
dict:to_list(dict:store(foo, true, dict:new())) }),
Term = dict:store(foo, true, dict:new()),
Term = decode(Bert).