[Distributions] Implement Expon distribution#1
Merged
forfudan merged 8 commits intomojomath:mainfrom Mar 4, 2026
Merged
Conversation
Member
Author
|
@forfudan Please check if the format, method names etc look good and if I need to make any other changes. I tried to follow |
forfudan
approved these changes
Mar 4, 2026
Member
forfudan
left a comment
There was a problem hiding this comment.
@shivasankarka I did some changes to your PR and merged it.
- Expon → Exponential, to be more self-explanatory as other distributions.
- RVContinuousLike → ContinuouslyDistributed, same as above, this is a not-so-pretty name of scipy (C-style)
- Remove the Copyable and Movable trait from Exponential because the ContinuouslyDistributed trait alreay contains them.
- Remove some unused imports.
- For
logcdf, uselog(-expm1(-y))instead oflog1p(-exp(-y))for better stability when x -> loc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exponential Distribution
This PR introduces an implementation of the continuous exponential distribution,
Expon.The implementation supports the standard parameterisation with
locandscale(fields ofExpon) enabling shifting and scaling of the exponential distribution.Traits
This PR also introduces a new trait,
RVContinuousLike, designed to parameterise continuous probability distributions (to mimicscipy.stats.rv_continous). At present, the trait defines only the core functionality common to continuous random variables.Exponis the first distribution to conform to this trait. Support will be extended to additional continuous distributions in subsequent PRs.