fix: Read bash VERSION as env var in Python workflow script#9
Merged
mogglemoss merged 1 commit intomasterfrom Feb 28, 2026
Merged
fix: Read bash VERSION as env var in Python workflow script#9mogglemoss merged 1 commit intomasterfrom
mogglemoss merged 1 commit intomasterfrom
Conversation
The previous Python one-liner attempted to use `{VERSION}` as an f-string, but `VERSION` was a bash variable. This correctly passes the bash variable as an environment variable into Python to ensure the regex successfully finds and updates it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Set version infostep in the GitHub Actions workflow.Context
The previous attempt to replace
sedwith Python failed because it tried to evaluate a Python f-string ({VERSION}) referencing a Bash variable that Python didn't know about.Approach
By explicitly passing
VERSIONas an environment variable (VERSION="$VERSION" python -c ...), the Python script can safely read it viaos.environ.get('VERSION')and correctly inject the version string into__init__.py.