Skip to content

feat: To-Do list bug fixes and release prep#7

Merged
mogglemoss merged 2 commits intomasterfrom
feature/release-prep-and-bugfixes
Feb 28, 2026
Merged

feat: To-Do list bug fixes and release prep#7
mogglemoss merged 2 commits intomasterfrom
feature/release-prep-and-bugfixes

Conversation

@mogglemoss
Copy link
Owner

Summary

This PR implements all 5 items requested in the to-do list:

  1. Wormhole Config Screen: The 'Save' button now correctly saves settings and reloads map sources without closing the configuration dialog.
  2. Automatic Versioning: The GitHub Actions workflow now automatically injects the latest release tag (e.g., v2.1.9-rc.1) into __init__.py during the build. This ensures the correct version is always displayed in the application title bar.
  3. UI Wording: Renamed lingering instances of 'Map Sources' to 'Wormhole Sources' across the UI (dialog title, status bar).
  4. AUR Packaging: The Linux build workflow now archives the raw PyInstaller output into a ShortCircuit-Linux-x86_64.tar.gz file and attaches it to the GitHub Release. This provides a clean source for Linux users building shortcircuit-bin via the AUR.
  5. Update Dialog Fix: Resolved an issue where the 'Download now' button in the new version notification dialog did nothing on Linux AppImages. It now utilizes the same xdg-open environment clearing fix used by the SSO Login button.

This commit addresses several items from the to-do list:

1.  **Wormhole Config Screen - Save without closing:**
    - Modified :
        - The 'Save' button in the Wormhole Sources Configuration dialog now saves settings without closing the window.
        - A new  method handles the saving logic and emits a  signal.
        - The  method now only closes the dialog after calling .

2.  **Automatic Version Number Updates:**
    - Modified :
        - The build workflow now directly updates the  string in  with the GitHub release tag () or a  version for non-tag builds.
        - This ensures the application's title bar accurately reflects the version.

3.  **Rename 'Map Sources' to 'Wormhole Sources' (partial):**
    - Modified :
        - Changed the window title from 'Map Sources Configuration' to 'Wormhole Sources Configuration'.
    - Modified :
        - Updated text in  and  from 'Map Sources' to 'Wormhole Sources'.

4.  **AUR Packaging - Linux .tar.gz:**
    - Modified :
        - Added a step to the  job to create a  archive of the PyInstaller output.
        - This  artifact is now uploaded alongside the  to GitHub Releases, providing a suitable source for AUR  packages.
This commit addresses task #5:
- The 'Download now' button in the update dialog was unresponsive on Linux AppImage builds because  failed to launch the default browser due to bundled library conflicts.
- Replaced the call with  and cleared  (similar to the EvE login fix) to ensure the release URL opens correctly.
- Also fixed a minor indentation issue in .
@mogglemoss mogglemoss merged commit e27cb46 into master Feb 28, 2026
1 of 3 checks passed
@mogglemoss mogglemoss deleted the feature/release-prep-and-bugfixes branch February 28, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant