fix: incorrect return type when using union types as Res or Req in defineInvoke #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in TypeScript, Conditional Types are distributive1, this means when:
…
invokeis of type((req: A, invokeRequest?: unknown) => Promise<C> | (req: B, invokeRequest?: unknown) => Promise<C>), which is unwanted. The expected type should be(req: A | B, invokeRequest?: unknown) => Promise<C>. The fix wraps the type into[T]to avoid this behavior.This pull request also adds the missing
@vitest/coverage-v8dependency and excludessemver@6.3.1fromtrustPolicy. As pnpm does not like the comments in the YAML2, I will write the reason here:electron@39.2.6(latest ATM) depends on@electron/get@2.0.3(^2.0.0) which dependes onsemver@6.3.1(^6.2.0).Footnotes
https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#distributive-conditional-types ↩
https://github.com/pnpm/pnpm/issues/2008 ↩