Fix memory exception when getting tags #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermaneerajin
suggested changes
Nov 27, 2017
Contributor
vermaneerajin
left a comment
vermaneerajin
left a comment
There was a problem hiding this comment.
This fix will work only for default context i.e. web. There are projects which have multiple context for multiple languages. This must cover all the contexts, Please check.
Author
|
Ok i replaced 'web' with $parent->get('context_key') this should work for any context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are allot of articles the get tags processor fires an memory exception > 500MB.
This can be fixed by getting the ID's directly instead of getting all the article objects.
Would be great if you could add this to the next version.