Conversation
|
Added all your code and removed the one you removed and it is working fine with one grid. |
|
In the config files, start, end should be lists and grid should be a list of lists. |
|
@traversc You should properly add an example of using this to the |
|
Here is my current config file (pretty rough outline of some areas, but just to test): |
|
Brilliant! I'm currently running multiple workers to accomplish this for a few towns in my area. Would love to see this merged in so I only need to run 1 worker. |
|
I got this to work by manually editing all the changes into the latest version EXCEPT I have to remove the lines
This makes it work, but with holes in the middle of every 4 circles, because every other row is supposed to be shifted. (http://i.imgur.com/nqtRm80.png) |
| lat = (config.MAP_END[0] + config.MAP_START[0]) / 2 | ||
| lon = (config.MAP_END[1] + config.MAP_START[1]) / 2 | ||
| return lat, lon | ||
| if isinstance(config.GRID[0], (int, long, float, complex)): |
There was a problem hiding this comment.
I'm not a fan of checking everywhere whether config value is an int, or a list. It's better to convert old value to new format in a single place.
Moreover, if GRID can be a list, then GRID[0] may raise an IndexError.
|
Could you rebase off master? |
|
Good points, about converting it to a standard format early on. In my own map, I converted to using a hexagonal grid, since it is more space efficient. We can no longer brute force large areas by throwing more accounts at it, so that would be another important change. |
|
@traversc this project uses a hex grid for quite a while now.... |
|
@Aiyubi didn't realize! That's how old my PR is haha. |
|
Looking forward to seeing this implemented @traversc. I hope you can get the changes in after a rebase :-) |

I modified the code to allow for multiple grids - important when trying to cover along a diagonal coast for example. You can see an example here: http://imgur.com/a/fxI4f. Should still work with only one grid.
Also, if you could add in pushbullet support directly, that would be sweet (https://github.com/Readdeo/PGOnotify).