Admin, Maps, and Dateformatter#52
Admin, Maps, and Dateformatter#52nchutchind wants to merge 5 commits intomodolabs:masterfrom nchutchind:master
Conversation
…from ICSDataParser to the correct name of ICSAthleticParser. Added check to see if a Photo publish date had been set and not try to format an empty date. Also, added photo description to the list of properties set for an image from RSS. Modified the photo show template to only attempt to show description if it exists and only show photoDate if it exists. Added check to HTTPDataResponse.php so that when we determine whether or not there has been an HTTP error, we also make sure that out url started with "http". This was causing errors to be set on the object when some other class (which I can't recall now) was using the HTTPData classes to obtain data from files on the system, rather than files via URL.
…lt no matter how many placemarks were added. Modified Admin module css and js to allow for dynamic groups that extend to more than one line to fit without overlapping content. Add several groups to the Maps app to see this. Modified the DateFormatter to allow for defining and passing in your own patterns. If the parameter you pass in is non-numeric, then we don't bother looking at the preset constants and instead use whatever pattern was passed in. Changed GoogleJSMap to get the Description from the KML file since there is no subtitle entry. Also changed several occurrences of misnamed variables.
|
Ok, so you're saying that, if the KML file has a <snippet> entry, the app will use that? Where should we go from here? Should I change back the "description" change I made and recommit? |
|
I apologize if I'm doing this wrong. :) This is my first foray into open source development, as well as git and github in general. |
|
Hi, I didn't realize GitHub didn't give notifications for replies to comments, so apologies about the late reply. Thanks for the new commit. I think what you're doing is cool, but it might be easier on us in the future if each pull request contains changes to just one module or library, as we track them independently (although I think GitHub won't let you have multiple pull requests on the same repo, so that is a limitation we have to live with). |
2 participants
I'm not familiar with github or git, so I hope I'm doing this right.
Removed break that was causing Maps to display an infowindow by default no matter how many placemarks were added.
Modified Admin module css and js to allow for dynamic groups that extend to more than one line to fit without overlapping content. Add several groups to the Maps app to see this.
Modified the DateFormatter to allow for defining and passing in your own patterns. If the parameter you pass in is non-numeric, then we don't bother looking at the preset constants and instead use whatever pattern was passed in.
Changed GoogleJSMap to get the Description from the KML file since there is no subtitle entry. Also changed several occurrences of misnamed variables.