This repository was archived by the owner on Jul 14, 2025. It is now read-only.
Merged
Conversation
- use setuptools_scm to generate version number, normal releases will use the tagged version (ie 1.9.1), versions installed from source will append the git commit number to the version number (ie 1.9.1.dev61+g4584c93) - use io.open() to read text files to correctly handle utf-8 characters - use pip to parse requirements.txt - update classifiers to specify python and django versions supported - wheel distributions can now be built using `python setup.py bdist_wheel`
- target oldest currently supported database servers, travis currently defaults to PostgreSQL 9.2 which isn't supported anymore. - move database dependencies out of travis.yml into test_requirements.txt and pin to minimum versions recommended by django. See https://docs.djangoproject.com/en/1.11/ref/databases/ - remove unnecessary database setup. See modoboa/modoboa#1340 - create binary wheels when a tag is pushed
required for Django 1.11 upgrade
Author
Member
|
@Fyfe No, it is not ready yet. |
ghost
mentioned this pull request
11 tasks
it can provide useful information when you break something
ghost
mentioned this pull request
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 74.32% 74.29% -0.03%
==========================================
Files 23 23
Lines 2029 2035 +6
==========================================
+ Hits 1508 1512 +4
- Misses 521 523 +2
Continue to review full report at Codecov.
|
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds will currently fail until Modoboa 1.10.0 is tagged, this build shows the other changes don't break anything.
refactor setup.py
use setuptools_scm to generate version number, normal releases will use the tagged version (ie 1.9.1), versions installed from source will append the git commit number to the version number (ie 1.9.1.dev61+g4584c93)
use io.open() to read text files to correctly handle utf-8 characters
use pip to parse requirements.txt
update classifiers to specify python and django versions supported
wheel distributions can now be built using
python setup.py bdist_wheelfix travis setup
target oldest currently supported database servers, travis currently defaults to PostgreSQL 9.2 which isn't supported anymore.
move database dependencies out of travis.yml into test_requirements.txt and pin to minimum versions recommended by django.
See https://docs.djangoproject.com/en/1.11/ref/databases/
remove unnecessary database setup.
See Fix test database setup modoboa#1340
create binary wheels when a tag is pushed
add a fix for Improved email parser modoboa#1330
Depends On