support sets #9
Draft
support sets #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
condiderations: - this implementation clashes a bit with - current implementation follows rest of the convention in the lib, could instead/also expose methods on the generic Set type
Collaborator
|
Not against it, For performance reasons the setz package seems resonable, supporting mutations. But is the bool vs struct that much different or it the reason looking for eg effective Intersection, Difference and so on operations? If so, that might be a good reason to add them on a key level on in |
crholm
reviewed
Oct 27, 2025
| } | ||
|
|
||
| func Union[A comparable](set1 Set[A], set2 Set[A]) Set[A] { | ||
| set := make(Set[A]) |
Collaborator
There was a problem hiding this comment.
probably should guess a size here, at least max(len(set1), len(set2))
crholm
reviewed
Oct 27, 2025
| } | ||
|
|
||
| func Intersection[A comparable](set1 Set[A], set2 Set[A]) Set[A] { | ||
| set := make(Set[A]) |
Collaborator
There was a problem hiding this comment.
probably should guess a size here, at least min(len(set1), len(set2))
crholm
reviewed
Oct 27, 2025
| } | ||
|
|
||
| func Difference[A comparable](set1 Set[A], set2 Set[A]) Set[A] { | ||
| set := make(Set[A]) |
Collaborator
There was a problem hiding this comment.
probably should guess a size here, at least max(len(set1), len(set2))?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
considerations:
slicez.Set()