Skip to content

Conversation

@kraem
Copy link

@kraem kraem commented Oct 17, 2024

breaking change.

can handle both

CreateLoggerMiddleware(LoggerConfig{}, ...)

and

CreateLoggerMiddleware(DefaultLoggerConfig,, ...)

@kraem kraem requested review from joeledstrom and larsve October 17, 2024 13:14
Copy link
Collaborator

@larsve larsve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how many depends on EAL, but I would prefer to add this as a non-breaking change, i.e. add a new public method that take the new confg param and change CreateLoggerMidleware to return the result of the new method with an empty config.

@larsve
Copy link
Collaborator

larsve commented Oct 30, 2024

Maybe we should think of adding a second type of skipper, that just skip logging (unless there is an error). We use that to "mute" all logging of k8s health checks that otherwise would get logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants