Skip to content

[bugfix] fix contiguous#96

Merged
tastelikefeet merged 1 commit intomodelscope:mainfrom
hjh0119:fix_contiguous
Mar 2, 2026
Merged

[bugfix] fix contiguous#96
tastelikefeet merged 1 commit intomodelscope:mainfrom
hjh0119:fix_contiguous

Conversation

@hjh0119
Copy link
Copy Markdown
Collaborator

@hjh0119 hjh0119 commented Mar 2, 2026

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the qwen3_next.py model by explicitly enforcing memory contiguity for a tensor after a transpose operation. This modification is essential for maintaining the correct memory layout, which can prevent errors or performance issues in subsequent tensor manipulations, particularly within distributed or parallel computing environments.

Highlights

  • Tensor Memory Layout: Ensured that the res tensor is contiguous after a transpose operation within the _gated_delta_net_forward function. This prevents potential issues with subsequent operations that expect contiguous memory, especially in parallel processing contexts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/twinkle/model/megatron/model/gpts/qwen3_next.py
    • Added .contiguous() call to a transposed tensor to ensure memory contiguity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a potential bug by ensuring a tensor is contiguous in memory after a transpose operation. The addition of .contiguous() is a standard practice in PyTorch to prevent runtime errors when subsequent operations, such as certain parallel communication primitives, require a contiguous memory layout. The change is correct and improves the robustness of the code.

@tastelikefeet tastelikefeet merged commit bbbeddd into modelscope:main Mar 2, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants