Skip to content

add more comment for node resouces #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastelikefeet merged 1 commit into from
Feb 28, 2026
Merged

add more comment for node resouces #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/twinkle/infra/_ray/resource_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ def __init__(self, nproc_per_node: int, ncpu_proc_per_node: int, groups: List[De
if cpu_proc_count > 0:
cpu_nnodes = math.ceil(cpu_proc_count / ncpu_proc_per_node)
assert cpu_nnodes <= len(self.nodes), (f'Not enough nodes for CPU processes, required nodes: {cpu_nnodes}, '
f'available: {len(self.nodes)}')
f'available: {len(self.nodes)}, ensure your ray cluster '
f'has enough nodes, or '
f'setting `twinkle.initialize(nproc_per_node=N(default 8), ...) '
f'to reduce per node GPU usage.`')
for i in range(cpu_nnodes):
node = self.nodes[i]
node_cpu = int(node['Resources']['CPU'])
Expand Down
Loading