Skip to content

modify cookbook #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meichangsu1 merged 11 commits into from
Feb 13, 2026
Merged

modify cookbook #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c6ace7f
feat(tests): replace manual sp_group retrieval with module attribute
meichangsu1 Feb 11, 2026
939466f
feat(tests): improve kernel availability check in test_function_kernel
meichangsu1 Feb 13, 2026
e344ba2
Merge branch 'dev' into kernels_unittest_fix_ljl
meichangsu1 Feb 13, 2026
f47dbc7
Merge remote-tracking branch 'origin/dev' into kernels_unittest_fix_ljl
meichangsu1 Feb 13, 2026
d6dd5c3
wip
meichangsu1 Feb 13, 2026
7a783d4
wip
meichangsu1 Feb 13, 2026
2d4a19f
remove debug info
meichangsu1 Feb 13, 2026
1d8094d
Merge remote-tracking branch 'origin/dev' into kernels_unittest_fix_ljl
meichangsu1 Feb 13, 2026
1a6d0ca
Merge remote-tracking branch 'origin/dev' into kernels_unittest_fix_ljl
meichangsu1 Feb 13, 2026
2b35007
feat: add ep/sp FSDP MoE finetuning entry and update script
meichangsu1 Feb 13, 2026
c365198
Merge remote-tracking branch 'origin/dev' into kernels_unittest_fix_ljl
meichangsu1 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ pip install -e .
| --------------------------------- | --------------- | ------------------------------------------------- |
| FSDP finetuning | transformers | [Script](cookbook/transformers/fsdp2.py) |
| FSDP MoE finetuning | transformers | [Script](cookbook/transformers/fsdp2_moe.py) |
| ep/sp FSDP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py) |
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The markdown formatting for this line has incorrect padding, which misaligns the table. Please adjust the spacing to align with the other rows.

Additionally, this new entry makes the next line for EP MoE finetuning confusing, as both point to the same script. Since this script now has sequence parallelism enabled by default (ulysses_size = 2), the EP MoE finetuning entry is misleading. It would be clearer to update the existing line rather than adding a new one.

Suggested change
| ep/sp FSDP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py) |
| ep/sp FSDP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py) |

| EP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py) |
| pp/tp/cp finetuning | megatron | [Script](cookbook/megatron/tp.py) |
| pp/tp/cp MoE finetuning | megatron | [Script](cookbook/megatron/tp_moe.py) |
Expand Down
2 changes: 2 additions & 0 deletions cookbook/transformers/ep_fsdp_qwen3_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@
# 4 gpus, dp=2, ep=2
dp_size = 2
ep_size = 2
ulysses_size = 2
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding ulysses_size makes the script less flexible. It's better to make it configurable via an environment variable, similar to how NUM_LAYERS is handled in this file. This would allow users to easily enable or disable sequence parallelism without modifying the code.

Suggested change
ulysses_size = 2
ulysses_size = int(os.environ.get('ULYSSES_SIZE', 2))


device_mesh = DeviceMesh(
device_type=Platform.get_platform().device_prefix(),
mesh=np.arange(dp_size * ep_size).reshape(dp_size, ep_size),
mesh_dim_names=('dp', 'ep'),
ulysses_size=ulysses_size, # enable sp
)

twinkle.initialize(
Expand Down
Loading