Skip to content

sp fix ci test hang #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meichangsu1 merged 2 commits into from
Feb 11, 2026
Merged

sp fix ci test hang #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ace7f
feat(tests): replace manual sp_group retrieval with module attribute
meichangsu1 Feb 11, 2026
bcfb465
feat(tests): remove unused import in sequence parallel test
meichangsu1 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tests/sequence_parallel/test_sequence_parallel_single_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

from twinkle.model.transformers.strategy.sequence_parallel import (
DistributedAttention,
_get_sp_group_from_device_mesh,
sequence_parallel,
)
from twinkle.model.transformers.strategy import NativeFSDPStrategy
Expand Down Expand Up @@ -181,7 +180,7 @@ def _run_worker_single_attn(rank: int, world_size: int, port: int, padding: bool
sp_size = world_size
device_mesh = DeviceMesh.from_sizes(dp_size=world_size, ulysses_size=sp_size, device_type="cuda")
_setup_sp(device_mesh, sp_size)
sp_group = _get_sp_group_from_device_mesh(device_mesh, sp_size)
sp_group = sequence_parallel._sp_group

batch_size = 2
unpad_seq_len = 127 if padding else 128
Expand Down Expand Up @@ -271,7 +270,7 @@ def _run_worker_single_attn_fsdp(rank: int, world_size: int, port: int):
# For FSDP+SP, SP is derived from dp/fsdp ranks. Use fsdp=world, dp=1.
device_mesh = DeviceMesh.from_sizes(fsdp_size=world_size, dp_size=1, ulysses_size=sp_size, device_type="cuda")
_setup_sp(device_mesh, sp_size)
sp_group = _get_sp_group_from_device_mesh(device_mesh, sp_size)
sp_group = sequence_parallel._sp_group

batch_size = 2
unpad_seq_len = 128
Expand Down
Loading