-
Notifications
You must be signed in to change notification settings - Fork 22
fix ci test #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
fix ci test #51
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bc3eea5
feat(tests): add sequence parallel single attention test
meichangsu1 4858e37
wip
meichangsu1 1855ed7
feat(tests): enhance sequence parallel attention test determinism
meichangsu1 cb6e343
remove __init__
meichangsu1 37774fb
feat(sequence_parallel): refactor config handling and remove padding-…
meichangsu1 4b2215e
feat(sequence_parallel): enforce flash_attention_2 for packed batches
meichangsu1 f9a8f78
feat(sft): add single controller SP packing example for Qwen2.5-7B
meichangsu1 2086e87
fix loss computation bug
meichangsu1 2547659
feat(cookbook): add single controller SP example and reorganize trans…
meichangsu1 db97bb2
refactor(tests): move sequence parallel attention test to dedicated d…
meichangsu1 74993e3
feat: add sequence parallelism instructions and clean up imports
meichangsu1 c385e8b
refactor
meichangsu1 488d648
feat: update training script with local mode and evaluation
meichangsu1 6783a9a
feat(transformers): remove unused imports in sequence_parallel module
meichangsu1 33766a1
feat(tests): replace manual sp_group retrieval with module attribute
meichangsu1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/bin/bash | ||
| # To enabele sequence parallelism, please set ulysses_size > 1 | ||
| # device_mesh = DeviceMesh( | ||
| # device_type="cuda", | ||
| # mesh=np.arange(4).reshape(2, 2), | ||
| # mesh_dim_names=("dp", "fsdp"), | ||
| # ulysses_size=2, | ||
| # ) | ||
| # | ||
| CUDA_VISIBLE_DEVICES=0,1,2,3 torchrun --nproc_per_node=4 sp_fsdp_dense.py |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
data_sliceparameter of thecreate_datasetfunction is currently being ignored due to the hardcodedrange(500). This can lead to unexpected behavior as calls fromevalandtrainwith differentdata_slicevalues will not have the intended effect. To fix this and restore the expected behavior, the function should use thedata_sliceparameter that is passed to it.