-
Notifications
You must be signed in to change notification settings - Fork 22
Add rl example #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add rl example #45
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b1652bc
update sampler
Yunnglin 7ce9d39
update sampler
Yunnglin bd2e607
updat
Yunnglin b20d683
Merge branch 'dev' into add_rl_example
Yunnglin de16401
update sampler
Yunnglin c001433
update cpu env
Yunnglin c3f36e1
update compat
Yunnglin b69b888
update
Yunnglin 546ae09
update
Yunnglin fe82fda
update
Yunnglin 994d5d8
Merge branch 'dev' into add_rl_example
Yunnglin 57e4482
Merge branch 'add_rl_example' of https://github.com/modelscope/twinkl…
Yunnglin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generated sampler client still subclasses
twinkle.sampler.base.Sampler, but the generatedsample()now returnsDict[str, Any]instead ofSampleResponse, diverging from the abstract base class contract. Either adjust generation to not subclassSamplerfor HTTP wrappers, or generate code that convertsresponse.json()intoSampleResponseto keep the public API consistent.