fix transformers model loading#150
Merged
tastelikefeet merged 1 commit intomodelscope:mainfrom Apr 10, 2026
Merged
Conversation
Jintao-Huang
approved these changes
Apr 10, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the initialization logic for MultiLoraTransformersModel and TransformersModel to support automatic model class inference and configuration loading. The feedback identifies several issues, including a potential TypeError due to a missing None check on model_id before downloading, and the requirement to respect the trust_remote_code parameter from kwargs instead of hardcoding it. Additionally, MultiLoraTransformersModel should be updated to support initialization from a configuration when model_id is absent to ensure consistency across the models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).