Merged
Conversation
hjh0119
approved these changes
Apr 9, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request refines the Dockerfile and installation scripts by updating package installations, including adding specific versions for numpy, vllm, transformer_engine, megatron_core, flash-attention, and flash-linear-attention. It also standardizes the use of Qwen3_5Template across numerous example and documentation files, replacing the generic Template, and updates model IDs in documentation. Review feedback points out a potential compatibility concern with the fixed numpy==2.2 version and suggests re-introducing a version constraint for the datasets package in pyproject.toml to prevent future breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).