Skip to content

Conversation

@casella
Copy link
Contributor

@casella casella commented Feb 28, 2020

The Modelica/Resources/Scripts contains a Dymola directory. I understand the MSL should be shipped free of tool-specific annotations and resources, which every tool vendor can then add at will in the version shipped with the tool.

@casella
Copy link
Contributor Author

casella commented Feb 28, 2020

I guess this could be re-added in the future when plot annotations are standardized.

Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These scripts are referenced in the MSL.

Generally, it does not hurt to have them inside MSL as they are clearly put in a tool-specific directory. Once we have the new standardized plot commands and base the MSL on the new specification, the new project leaders can care for it to update the tool-specific plot commands to the standardized ones.

Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @beutlich. They are clearly marked as tool-dependent. After a later standardisation they can be moved to a neutral directory but not for now.

@dietmarw dietmarw closed this Feb 28, 2020
@beutlich beutlich added this to the never milestone Feb 28, 2020
@beutlich beutlich added the invalid Invalid issue label Feb 28, 2020
@beutlich beutlich removed the request for review from HansOlsson February 28, 2020 15:14
@casella
Copy link
Contributor Author

casella commented Feb 28, 2020

My understanding was that the "Standard" Library should only contain code written according to the Modelica Language Specification in force, i.e., v. 3.4. These scripts clearly are not.

In the past we also removed all tool-specific annotations from the MSL, even after standardizing vendor annotations, exactly for the same reason.

I thought we had different rules, but it's not me leading the game at this moment :)

@casella casella deleted the remove-dymola-directory branch July 7, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Invalid issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants