-
Notifications
You must be signed in to change notification settings - Fork 176
Fix dimension of conditionally declared components #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5088fbd to
d3d356d
Compare
HansOlsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The array dimension is so long that it becomes hard to read. Wouldn't it be possible to just say:
RealInput portsData_zeta_out_internal[:]=portsData.zeta_out if ....;
(and similarly for others).
|
I rather prefer to have the dimensions explicit. |
|
How about having a common protected parameter for this size - something like |
Yes, that is sensible, but probably more invasive (than just the four lines as now). I hope that @casella will have a look at it and update this PR accordingly. |
casella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I hope there is at least one test case for this addition.
|
If you really insist I can accept giving the array dimensions. |
|
Considering @perost's edit from #2574 (comment), this is wrong. |
Modelica.Fluid.Examples.TraceSubstances.RoomCO2WithControls has use_portsData = false and nPorts =4. |
close #2574