Skip to content

Conversation

@beutlich
Copy link
Member

@beutlich beutlich commented Jun 1, 2018

close #2574

@beutlich beutlich added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label Jun 1, 2018
@beutlich beutlich added this to the MSL3.2.3 milestone Jun 1, 2018
@beutlich beutlich requested review from HansOlsson and casella June 1, 2018 11:19
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The array dimension is so long that it becomes hard to read. Wouldn't it be possible to just say:
RealInput portsData_zeta_out_internal[:]=portsData.zeta_out if ....;
(and similarly for others).

@beutlich
Copy link
Member Author

beutlich commented Jun 5, 2018

I rather prefer to have the dimensions explicit.

@HansOlsson
Copy link
Contributor

HansOlsson commented Jun 5, 2018

How about having a common protected parameter for this size - something like nPortsOr0 (preferably more sensible name)?

@beutlich
Copy link
Member Author

beutlich commented Jun 5, 2018

How about having a common protected parameter for this size

Yes, that is sensible, but probably more invasive (than just the four lines as now).

I hope that @casella will have a look at it and update this PR accordingly.

Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I hope there is at least one test case for this addition.

@HansOlsson
Copy link
Contributor

If you really insist I can accept giving the array dimensions.

@beutlich
Copy link
Member Author

beutlich commented Jun 5, 2018

Considering @perost's edit from #2574 (comment), this is wrong.

@beutlich beutlich closed this Jun 5, 2018
@beutlich beutlich deleted the issue2574-dimension branch June 5, 2018 17:59
@beutlich beutlich modified the milestones: MSL3.2.3, never Jun 5, 2018
@beutlich
Copy link
Member Author

beutlich commented Jun 5, 2018

I hope there is at least one test case for this addition.

Modelica.Fluid.Examples.TraceSubstances.RoomCO2WithControls has use_portsData = false and nPorts =4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potentially illegal conditional components in Fluid.Vessels

3 participants