Skip to content

Fix heat transfer adaptors #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tobolar wants to merge 2 commits into from
Closed

Fix heat transfer adaptors #2567

tobolar wants to merge 2 commits into from

Conversation

@tobolar
Copy link
Contributor

@tobolar tobolar commented May 30, 2018 •
edited
Loading

Adapted icon color and name of adaptors in Modelica.Thermal.HeatTransfer.Components to be compliant to conventions used in other domanis

@tobolar tobolar requested review from AHaumer and StephanZiegler May 30, 2018 10:05
@tobolar tobolar added bug Critical/severe issue L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer P: high High priority issue labels May 30, 2018
@tobolar tobolar added this to the MSL3.2.3 milestone May 30, 2018
@tobolar tobolar added enhancement New feature or enhancement and removed bug Critical/severe issue labels May 30, 2018
beutlich
beutlich previously requested changes May 30, 2018
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not clean. I'll fix it later.

tobolar added 2 commits May 30, 2018 13:41
@tobolar @beutlich
Change color of adaptors' icons in Modelica.Thermal.HeatTransfer.Comp…
44e79c8 
…onents to comply with conventions

refs #2430 and #2562
@tobolar @beutlich
Rename adaptors in Modelica.Thermal.HeatTransfer.Components to "Gener…
193425b 
…al" adaptors to be consistent to general adaptors from another domains
@beutlich beutlich dismissed their stale review May 30, 2018 11:42

Removed merge commits

@AHaumer
Copy link
Contributor

AHaumer commented May 30, 2018

could be closed since included in #2570

@AHaumer AHaumer added duplicate Duplicate issue and removed P: high High priority issue labels May 31, 2018
AHaumer
AHaumer requested changes May 31, 2018
View reviewed changes
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already included in my PR #2570, could be closed

@dietmarw dietmarw closed this Jun 1, 2018
@beutlich beutlich modified the milestones: MSL3.2.3, never Jun 1, 2018
@tobolar tobolar deleted the fixHeatTransferAdaptors branch June 4, 2018 11:49
@beutlich beutlich removed the request for review from StephanZiegler June 15, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AHaumer AHaumer AHaumer requested changes

@beutlich beutlich beutlich left review comments

Assignees

No one assigned

Labels

duplicate Duplicate issue enhancement New feature or enhancement L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer

Projects

None yet

Milestone

never

Development

Successfully merging this pull request may close these issues.

4 participants

@tobolar @AHaumer @beutlich @dietmarw