Skip to content

Automated windows build: build.bat #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandernikolic-v2c2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Automated windows build: build.bat #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ install(DIRECTORY ${PROJECT_SOURCE_DIR}/include/core DESTINATION include/DCPLib)

if(BUILD_ALL OR BUILD_ETHERNET)
find_package(Threads REQUIRED)
find_package(ASIO REQUIRED )
Copy link
Collaborator

@klausschuch klausschuch May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is ASIO on windows not ok?
We use ASIO on windows with vcpkg here https://github.com/eclipse-openmcx/openmcx/blob/add_dcp_support/CMakeLists.txt and don't have any problems.

Copy link
Author

@alexandernikolic-v2c2 alexandernikolic-v2c2 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: This change (+ if/else and "case-sensitive" asio find_package calls) can be omitted.

This is me being used to case-paranoia, thus my bad.

As I read this information in the output of vcpkg:

asio provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(asio CONFIG REQUIRED)
  target_link_libraries(main PRIVATE asio::asio)

asio provides pkg-config modules:

  # A cross-platform C++ library for network and low-level I/O programming that provides developers with a consistent asynchronous model using a modern C++ approach.
  asio

I assumed by using the same case as output, I would also make sure to use the vcpkg-provided pkg-config modules. This is not the case though, as pkg-config is not used in CMakeLists.txt - I missed to see that.

Masking cmake/FindASIO.cmake by renaming revealed, that this file is used. To reduce future maintenance burden, removing this file and using the pkg-config way in cmake might be considered.

if(WIN32)
find_package(asio REQUIRED )
else(WIN32)
find_package(ASIO REQUIRED )
endif(WIN32)


##dcplib ethernet
add_library(Ethernet INTERFACE)
Expand Down Expand Up @@ -165,21 +170,30 @@ if(BUILD_ALL OR BUILD_XML)
endif(BUILD_ALL OR BUILD_XML)

if(BUILD_ALL OR BUILD_ZIP)
find_package(Zip REQUIRED)
set(ziplib_name "")
set(ziplib_target "")
if(WIN32)
set(ziplib_name "libzip")
set(ziplib_target "libzip::zip")
else(WIN32)
set(ziplib_name "Zip")
set(ziplib_target "ZIP::ZIP")
endif(WIN32)

add_library(Zip INTERFACE)
add_library(DCPLib::Zip ALIAS Zip)
find_package(${ziplib_name} REQUIRED)
add_library(${ziplib_name} INTERFACE)
add_library(DCPLib::Zip ALIAS ${ziplib_name})

target_link_libraries(Zip INTERFACE DCPLib::Xml ZIP::ZIP)
target_link_libraries(${ziplib_name} INTERFACE DCPLib::Xml ${ziplib_target})

target_include_directories(Zip INTERFACE
target_include_directories(${ziplib_name} INTERFACE
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include/zip>
$<INSTALL_INTERFACE:include/DCPLib/zip>
)

install(TARGETS Zip
install(TARGETS ${ziplib_name}
EXPORT DCPLib-targets
COMPONENT Zip
COMPONENT ${ziplib_name}
ARCHIVE DESTINATION lib
LIBRARY DESTINATION lib
RUNTIME DESTINATION bin)
Expand Down
76 changes: 76 additions & 0 deletions build.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
@echo off
set back=%cd%
set BUILD_CONFIG=Release

if not exist dependencies (mkdir dependencies)
cd dependencies

WHERE vcpkg --version >nul 2>nul
REM IF %ERRORLEVEL% NEQ 0 (ECHO vcpkg was not found && cd %back% && EXIT /b 1)
IF %ERRORLEVEL% NEQ 0 (
if not exist %cd%\vcpkg\scripts\buildsystems\vcpkg.cmake (
ECHO vcpkg was not found, installing
if not exist vcpkg (git clone https://github.com/microsoft/vcpkg.git)
cd vcpkg
if not exist vcpkg.exe ( bootstrap-vcpkg.bat -disableMetrics )
set VCPKG=%cd%\vcpkg\vcpkg.exe
%VCPKG% integrate install || ECHO Installed vcpkg locally
)
) ELSE (
ECHO vcpkg found
set VCPKG=vcpkg
)

%VCPKG% --version

cd %back%

cd dependencies
WHERE cmake --version >nul 2>nul
REM IF %ERRORLEVEL% NEQ 0 (ECHO cmake was not found && cd %back% && EXIT /b 1)
IF %ERRORLEVEL% NEQ 0 (
ECHO cmake was not found, installing
if not exist cmake.zip ( curl -L -o cmake.zip https://github.com/Kitware/CMake/releases/download/v4.0.0-rc5/cmake-4.0.0-rc5-windows-x86_64.zip )
REM if not exist cmake (tar -xf cmake.zip)
if not exist cmake (mkdir cmake && tar -xf cmake.zip --strip-components=1 -C cmake)
cd cmake
cd bin
set CMAKE=%cd%\cmake\bin\cmake.exe
) ELSE (
ECHO cmake found
set CMAKE=cmake
)

%CMAKE% --version

cd %back%

%VCPKG% install asio xerces-c libzip

if not exist build (mkdir build)

cd build
if not exist install (mkdir install)
set VCPKG_TC_FILE=C:/Users/%USERNAME%/Downloads/dcp_PR/DCPLib/dependencies/vcpkg/scripts/buildsystems/vcpkg.cmake
%CMAKE% .. -G "Visual Studio 17 2022" -A x64 -DCMAKE_TOOLCHAIN_FILE=%VCPKG_TC_FILE% -DCMAKE_INSTALL_PREFIX=install

%CMAKE% --build . --target=install --config %BUILD_CONFIG%

cd %back%


REM Build Examples

for /f "tokens=*" %%G in ('dir /b /a:d "example\*"') do (
echo Found %back%\example\%%G
if not exist %back%\build\example\%%G (mkdir %back%\build\example\%%G)
cd %back%\build\example\%%G
%CMAKE% %back%\example\%%G -G "Visual Studio 17 2022" -A x64 -DCMAKE_TOOLCHAIN_FILE=%VCPKG_TC_FILE% -DDCPLib_DIR=%back%\build\install\lib\DCPLib -DCMAKE_INSTALL_PREFIX=install
%CMAKE% --build . --config %BUILD_CONFIG%
REM copy /Y %back%\example\%%G\*.xml %back%\build\example\%%G
cd %back%
)

REM make sure the XML File is available for any build configuration!!! (e.g. master needs one)

run_test.bat %cd% %BUILD_CONFIG%
7 changes: 7 additions & 0 deletions example/master/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,11 @@ file(GLOB_RECURSE dcpmaster_src_files src/*.cpp src/*.h )
add_executable(dcpmaster ${dcpmaster_src_files})
target_link_libraries(dcpmaster DCPLib::Ethernet DCPLib::Master DCPLib::Xml)

add_custom_command(TARGET dcpmaster POST_BUILD
COMMAND "${CMAKE_COMMAND}" -E copy
${CMAKE_SOURCE_DIR}/Example-Slave-Description.xml
$<TARGET_FILE_DIR:dcpmaster>
COMMENT "Copied description XML file."
)

install(TARGETS dcpmaster DESTINATION bin)
12 changes: 11 additions & 1 deletion example/spring_damper_master/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,14 @@ file(GLOB_RECURSE dcp_msd_master_src_files src/*.cpp src/*.h )
add_executable(dcp_msd_master ${dcp_msd_master_src_files})
target_link_libraries(dcp_msd_master DCPLib::Ethernet DCPLib::Master DCPLib::Xml)

install(TARGETS dcp_msd_master DESTINATION bin)
add_custom_command(TARGET dcp_msd_master POST_BUILD
COMMAND "${CMAKE_COMMAND}" -E copy
${CMAKE_SOURCE_DIR}/MSD1-Slave-Description.xml
$<TARGET_FILE_DIR:dcp_msd_master>
COMMAND "${CMAKE_COMMAND}" -E copy
${CMAKE_SOURCE_DIR}/MSD2-Slave-Description.xml
$<TARGET_FILE_DIR:dcp_msd_master>
COMMENT "Copied description XML file."
)

install(TARGETS dcp_msd_master DESTINATION bin)
7 changes: 7 additions & 0 deletions example/struc_param_master/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,11 @@ file(GLOB_RECURSE struc_param_master_src_files src/*.cpp src/*.h )
add_executable(struc_param_master ${struc_param_master_src_files})
target_link_libraries(struc_param_master DCPLib::Ethernet DCPLib::Master DCPLib::Xml)

add_custom_command(TARGET struc_param_master POST_BUILD
COMMAND "${CMAKE_COMMAND}" -E copy
${CMAKE_SOURCE_DIR}/StrucParam-Slave-Description.xml
$<TARGET_FILE_DIR:struc_param_master>
COMMENT "Copied description XML file."
)

install(TARGETS struc_param_master DESTINATION bin)
13 changes: 13 additions & 0 deletions run_test.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
set back=%1
set BUILD_CONFIG=%2

echo > waiting.tmp
start cmd /c wrapper.bat %back%\build\example\slave\%BUILD_CONFIG% %back%\build\example\slave\%BUILD_CONFIG%\dcpslave.exe
cd %back%\build\example\master\%BUILD_CONFIG%
start /wait %back%\build\example\master\%BUILD_CONFIG%\dcpmaster.exe

:loop
if exist waiting.tmp goto :loop

taskkill /IM dcpslave.exe /F
cd %back%
3 changes: 3 additions & 0 deletions wrapper.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
cd %1
start /wait %2
del waiting.tmp