Implement SWMM-like variables and arithmetic in Epanet #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lukepbutler <lukepbutler@gmail.com>
|
Cursor Agent can help with this pull request. Just |
…d variables and arithmetic expressions support for review in PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for named variables and arithmetic expressions within EPANET's [RULES] section to enhance rule definition flexibility.
This PR integrates a math expression engine and extends EPANET's parsing and evaluation logic to allow users to define
VARIABLEs based on model attributes andEXPRESSIONs using arithmetic operations on these variables. These new constructs can then be used inIF/AND/ORclauses within the rules, providing more powerful and dynamic control over the network simulation.