Skip to content

Conversation

@alercunha
Copy link
Contributor

Summary

  • Add modern Python packaging with pyproject.toml (replaces setup.py)
  • Add multi-stage Dockerfile for building and testing
  • Add comprehensive CI workflow with build, test, and pylint
  • Fix error messages for brand/label character limits
  • Fix exit codes in lv2_validate_mod

Changes

Packaging

  • Replace setup.py with pyproject.toml
  • Add scripts/build.sh and scripts/test.sh for consistent build/test workflow

CI

  • Replace separate pylint.yml with unified build.yml workflow
  • Pylint runs as part of test.sh (no duplicate virtualenv creation)

Bug Fixes

  • Fix brand error message: "11 characters" → "16 characters"
  • Fix label error message: "16 characters" → "24 characters"
  • Add proper exit 1 codes to lv2_validate_mod error conditions

Docker

  • Multi-stage build (builder → tester → artifacts)
  • Clean test environment validates the built packages

Test plan

  • CI workflow runs automatically on push/PR
  • Docker build validates end-to-end: docker build -t lilvlib-build .

Ale Cunha added 5 commits January 17, 2026 17:41
The limits were updated to 16 (brand) and 24 (label) but the error
messages still referenced the old limits of 11 and 16 respectively.
Exit with code 1 on error conditions instead of bare exit (which
defaults to 0/success).
@falkTX falkTX merged commit 3b81800 into mod-audio:modernize Jan 18, 2026
1 check passed
falkTX pushed a commit that referenced this pull request Jan 18, 2026
Enhancements to modernize branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants