Skip to content

Template update: tighten up eslint config #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mockdeep merged 1 commit into from
Feb 11, 2026
Merged

Template update: tighten up eslint config #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .eslint_todo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,15 @@
// The point is for the user to remove these configuration records
// one by one as the offenses are removed from the code base.

export default [
import type {Linter} from "eslint";

const eslintTodo: Linter.Config[] = [
{
files: ["spec/javascript/controllers/file_upload_controller_spec.ts"],
rules: {
"@typescript-eslint/consistent-type-assertions": "off",
},
},
];

export default eslintTodo;
10 changes: 3 additions & 7 deletions eslint.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import importPlugin from "eslint-plugin-import";
import vitest from "eslint-plugin-vitest";
import js from "@eslint/js";
import stylistic from "@stylistic/eslint-plugin";
import tsParser from "@typescript-eslint/parser";
import tseslint from "typescript-eslint";
import {defineConfig} from "eslint/config";
import sortKeysFix from "eslint-plugin-sort-keys-fix";
Expand All @@ -28,19 +27,14 @@ export default defineConfig([
files: ["**/*.{js,mjs,cjs,ts,mts,cts}"],
languageOptions: {
globals: globals.browser,
parser: tsParser,
parserOptions: {
projectService: {
allowDefaultProject: ["stylelint.config.mjs"],
},
},
},
plugins: {
importPlugin,
js,
"sort-keys-fix": sortKeysFix,
stylistic,
vitest,
},
rules: {
"@stylistic/array-element-newline": ["error", "consistent"],
Expand All @@ -57,6 +51,8 @@ export default defineConfig([
["error", {anonymous: "always", named: "never"}],
"@typescript-eslint/consistent-indexed-object-style":
["error", "index-signature"],
"@typescript-eslint/consistent-type-assertions":
["error", {assertionStyle: "never"}],
"@typescript-eslint/explicit-member-accessibility": "off",
"@typescript-eslint/naming-convention": "off",
"@typescript-eslint/no-magic-numbers": "off",
Expand All @@ -65,7 +61,7 @@ export default defineConfig([
"func-style": ["error", "declaration"],
"max-len": ["error", 84, {ignoreUrls: true}],
"no-duplicate-imports": ["error", {allowSeparateTypeImports: true}],
"no-magic-numbers": "off",

"no-undefined": "off",
"one-var": ["error", "never"],
"sort-imports":
Expand Down