The Great Rewrite #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters, and simplify template methods
Refactored to use `const`, removed redundant `inline`, and simplified methods.
Changed to use `const`, `constexpr`, and `nodiscard`, simplified method implementations and adopted nested namespace syntax.
Simplified `equal` struct, replaced `std::is_same` with `std::is_same_v`, and updated template parameter syntax.
Updated `CMakeLists.txt` to enforce C++17, replaced custom C++11 feature flags with `cxx_std_17`, and utilized namespaced target aliases. Enhanced scripts to utilize modern CMake practices, improved Python/quom checks, and updated installation/export configurations.
Enabled testing setup via CMake with `TWEENY_BUILD_TESTS` option. This includes integration of Catch2 v3, a basic sanity test, and configuration for automatic test discovery.
Replaced `stacked` with `start` across the tween and tweenpoint classes for clarity and consistency. Added an overload for `seek` to support `uint32_t` time-based arguments. Extended tests to cover new functionality and ensure correctness.
Introduced an `event` namespace with the ` step_t ` type and accompanying response enum. Enhanced `tween` class with `on()` for registering `step` listeners. Updated internal `step` logic to trigger callbacks and added tests to validate `step` events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rewrite, focusing on normalizing and simplifying the API and also leveraging some new cool features introduced by C++17. It is still under construction but it is ready for commenting and contributions from the community.