Update EdgeMultiplay to support EdgeEvents#22
Open
ah1053 wants to merge 4 commits intoedge-eventsfrom
Open
Conversation
ah1053
requested review from
brucearmstrong,
franklin-huang-mobiledgex and
lgarner
franklin-huang-mobiledgex
left a comment
franklin-huang-mobiledgex
left a comment
There was a problem hiding this comment.
Minor comments on Dict and Hashtable conversion functions
EdgeMultiplay/Scripts/Util.cs
Outdated
| { | ||
| Dictionary<string, string> tags = new Dictionary<string, string>(); | ||
| Debug.Log("HashtableToDictionary: " + htags + ", Count: " + htags.Count); | ||
| if (htags == null || htags.Count == 0) |
There was a problem hiding this comment.
I think you can get rid of the check for htags.Count == 0. If htags is an empty hashtable, I think we want to return an empty dictionary instead of null (your for loop will already do that). (Same comment for the DictionaryToHashtable function)
EdgeMultiplay/Scripts/Util.cs
Outdated
Comment on lines
+177
to
+179
| if (htable == null || htable.Count == 0) | ||
| { | ||
| return dict; | ||
| } |
There was a problem hiding this comment.
hmm this should return null if htable is null. The code you had before was good, you just had to remove the check for htable.Count==0
brucearmstrong
approved these changes
Jul 12, 2021
franklin-huang-mobiledgex
approved these changes
Jul 12, 2021
gainsley
force-pushed
the
support-edge-events
branch
from
8f04bb0 to
d7da810
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.