Skip to content

Feature/flexible memo #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wjuan-mob wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Feature/flexible memo #3269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
45c9b7e
Add new flexible memo generator option to rth memo builder.
wjuan-mob Mar 23, 2023
7313923
Cleanup
wjuan-mob Mar 27, 2023
8ae53d4
Add helper functions for extracting data from authenticated sender an…
wjuan-mob Mar 27, 2023
f0e99a3
Expose flexible memo types and update test
wjuan-mob Mar 27, 2023
f0085c4
Expand rth test in transaction builder to use flexible memo generator
wjuan-mob Mar 27, 2023
1b8651e
lint
wjuan-mob Mar 27, 2023
c9b5ae3
lint
wjuan-mob Mar 27, 2023
6ed5b93
Remove todo, add fee check.
wjuan-mob Apr 11, 2023
e9905e0
fmt
wjuan-mob Apr 11, 2023
f453a24
Using trait instead of closures per pr feedback
wjuan-mob Apr 18, 2023
8c2ffd6
Remove unnecessary struct
wjuan-mob Apr 18, 2023
47fd4d1
Remove function based flexible memo generation. Just set the memo pay…
wjuan-mob Apr 19, 2023
73a708b
Update transaction/builder/src/memo_builder/rth_memo_builder.rs
wjuan-mob Apr 19, 2023
9c2b962
Update transaction/builder/src/memo_builder/rth_memo_builder.rs
wjuan-mob Apr 19, 2023
6b63747
Update transaction/builder/src/memo_builder/rth_memo_builder.rs
wjuan-mob Apr 19, 2023
7f9bef8
Update transaction/builder/src/memo_builder/rth_memo_builder.rs
wjuan-mob Apr 19, 2023
ae29bd4
Change error name
wjuan-mob Apr 24, 2023
205701c
Addig defaults
wjuan-mob Apr 25, 2023
2d92113
Changing constants to use named constants
wjuan-mob Apr 25, 2023
465ddc6
lint
wjuan-mob Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions transaction/builder/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2018-2022 The MobileCoin Foundation
// Copyright (c) 2018-2023 The MobileCoin Foundation

//! Utilities for creating MobileCoin transactions, intended for client-side
//! use and not intended to be used inside of enclaves.
Expand All @@ -22,9 +22,9 @@ pub mod test_utils;
pub use error::{SignedContingentInputBuilderError, TxBuilderError};
pub use input_credentials::InputCredentials;
pub use memo_builder::{
BurnRedemptionMemoBuilder, DefragmentationMemoBuilder, EmptyMemoBuilder,
GiftCodeCancellationMemoBuilder, GiftCodeFundingMemoBuilder, GiftCodeSenderMemoBuilder,
MemoBuilder, RTHMemoBuilder,
BurnRedemptionMemoBuilder, DefragmentationMemoBuilder, EmptyMemoBuilder, FlexibleMemoPayload,
FlexibleMemoPayloads, GiftCodeCancellationMemoBuilder, GiftCodeFundingMemoBuilder,
GiftCodeSenderMemoBuilder, MemoBuilder, RTHMemoBuilder,
};
pub use reserved_subaddresses::ReservedSubaddresses;
pub use signed_contingent_input_builder::SignedContingentInputBuilder;
Expand Down
4 changes: 2 additions & 2 deletions transaction/builder/src/memo_builder/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2018-2022 The MobileCoin Foundation
// Copyright (c) 2018-2023 The MobileCoin Foundation

//! Defines the MemoBuilder trait, and the Default implementation
//! The memo builder for recoverable transaction history is defined in a
Expand All @@ -22,7 +22,7 @@ pub use defragmentation_memo_builder::DefragmentationMemoBuilder;
pub use gift_code_cancellation_memo_builder::GiftCodeCancellationMemoBuilder;
pub use gift_code_funding_memo_builder::GiftCodeFundingMemoBuilder;
pub use gift_code_sender_memo_builder::GiftCodeSenderMemoBuilder;
pub use rth_memo_builder::RTHMemoBuilder;
pub use rth_memo_builder::{FlexibleMemoPayload, FlexibleMemoPayloads, RTHMemoBuilder};

/// The MemoBuilder trait defines the API that the transaction builder uses
/// to ask the memo builder to build a memo for a particular TxOut.
Expand Down
Loading