-
Notifications
You must be signed in to change notification settings - Fork 16
Add DCAP evidence to BlockMetadataContents #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nick-mobilecoin
wants to merge
2
commits into
mobilecoinfoundation:main
Choose a base branch
from
nick-mobilecoin:nick/dcap-evidence-on-block-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| - Feature Name: dcap-evidence-in-block-metadata | ||
| - Start Date: 2023-12-01 | ||
| - MCIP PR: [mobilecoinfoundation/mcips#68](https://github.com/mobilecoinfoundation/mcips/pull/68) | ||
| - Tracking Issue: [mobilecoinfoundation/mobilecoin#2373](https://github.com/mobilecoinfoundation/mobilecoin/issues/2373) | ||
|
|
||
| # Summary | ||
| [summary]: #summary | ||
|
|
||
| Provide DCAP attestation evidence in the block metadata. This is the compliment | ||
| to the Attestation Verification Report (AVR) used in EPID. | ||
|
|
||
| # Motivation | ||
| [motivation]: #motivation | ||
|
|
||
| EPID SGX hardware is being phased out. The newer SGX machines use DCAP as the | ||
| attestation protocol. This MCIP is to provide the DCAP version of the evidence | ||
| in the block metadata so that chain integrity can be verified for blocks created | ||
| on the newer hardware. | ||
|
|
||
| # Guide-level explanation | ||
| [guide-level-explanation]: #guide-level-explanation | ||
|
|
||
| The `BlockMetatdataContents` in block versions 4 or greater contain either a | ||
| `DcapEvidence` or a `VerificationReport`. | ||
| (The `BlockMetatdataContents` was added in [MCIP-0043](0043-block-metadata.md)). | ||
| The `DcapEvidence` contains attestation evidence returned by the DCAP | ||
| attestation process. The `VerificationReport` contains the attestatoin evidence | ||
| returned by the EPID attestation process. | ||
|
|
||
| In general, block version 4 or greater is expected to only contain | ||
| `DcapEvidence`, but the `VerificationReport` is included for backwards | ||
| compatibility. | ||
|
|
||
| # Reference-level explanation | ||
| [reference-level-explanation]: #reference-level-explanation | ||
|
|
||
| The `BlockMetadataContents` uses a | ||
| [`oneof`](https://protobuf.dev/programming-guides/proto3/#oneof) to contain | ||
| either a `VerificationReport` or a `DcapEvidence`. This field is named | ||
| `attestation_evendence` to be generic enough to contain either type of evidence. | ||
|
|
||
| ## Protobuf schema | ||
|
|
||
| ```protobuf | ||
| message BlockMetadataContents { | ||
| /// The Block ID. | ||
| BlockID id = 1; | ||
|
|
||
| /// Quorum set configuration at the time of externalization. | ||
| QuorumSet quorum_set = 2; | ||
|
|
||
| // The attestation evidence for the enclave which generated the signature. | ||
| oneof attestation_evidence { | ||
| external.VerificationReport verification_report = 3; | ||
| external.DcapEvidence dcap_evidence = 5; | ||
| } | ||
|
|
||
| /// Responder ID of the consensus node. | ||
| ResponderId responder_id = 4; | ||
| } | ||
| ``` | ||
|
|
||
| # Drawbacks | ||
| [drawbacks]: #drawbacks | ||
|
|
||
| This requires a block version bump since it changes the `BlockMetadataContents`. | ||
| Consumers that only know about block version 3 will be unable to verify | ||
| `BlockMetadataContents` or the attestation evidence it contains. | ||
|
|
||
| # Rationale and alternatives | ||
| [rationale-and-alternatives]: #rationale-and-alternatives | ||
|
|
||
| The `VerificationReport` and `DcapEvidence` were disparate enough that it didn't | ||
| seem feasible to try and convert a `DcapEvidence` into a `VerificationReport`. | ||
|
|
||
| # Prior art | ||
| [prior-art]: #prior-art | ||
|
|
||
| None at this time. | ||
|
|
||
| # Unresolved questions | ||
| [unresolved-questions]: #unresolved-questions | ||
|
|
||
| None at this time. | ||
|
|
||
| # Future possibilities | ||
| [future-possibilities]: #future-possibilities | ||
|
|
||
| None at this time. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.