Conversation
|
Currently in Magnifik, when a user taps on the thumbnail image, the canvas will open centered relative to where the user tapped on the thumbnail (user taps top left, canvas opens zoomed in to top left). Does this PR change that behaviour? If it does, is there a way we can keep both use cases? |
… default behaviour
|
Thanks @marlowpayne! I've updated the code to reflect that and also made sure that option is enabled by default to keep backwards compatibility. I also added @donnielrt to get his feedback. |
There was a problem hiding this comment.
we might want to cache these properties to var horizontal = this.options.canvasScrollPosition.horizontal, and var vertical = this.options.canvasScrollPosition.vertical
|
@mikenikles was this intended to solve a project-specific issue? Curious what the motivation for the change was? |
|
Yes @donnielrt, this PR is a generalized approach to solve a project-specific issue that may be encountered by other users of Magnifik. |
|
Awesome, thanks @mikenikles! Like we discussed, let's get a quick round of QA for the change in the project, and we can get this bad boy merged! |
Adds the ability to set a default scroll position when an image is zoomed in.
Status: Ready for review
Reviewers: @marlowpayne @jnurse @donnielrt
Changes
canvasScrollPositionoptions objectNotes