Skip to content

Update SQLInjectionExample.java#210

Open
mobbeitan wants to merge 1 commit intoFortifyfrom
mobbeitan-patch-3
Open

Update SQLInjectionExample.java#210
mobbeitan wants to merge 1 commit intoFortifyfrom
mobbeitan-patch-3

Conversation

@mobbeitan
Copy link
Owner

No description provided.

Connection con = DriverManager.getConnection("jdbc:mysql://localhost:3306/db");

String query = "SELECT * FROM users WHERE username = '" + request.getParameter("username") + "';";
String query = "SELECT * FROM users WHERE username = '" + request.getParameter("username") + "';";
Copy link

@github-actions github-actions bot Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image SQL Injection fix is ready

Apply the following code change to fix SQL Injection issue detected by Fortify:

--- a/src/main/java/SQLInjectionExample.java
+++ b/src/main/java/SQLInjectionExample.java
@@ -1,3 +1,4 @@
+import java.sql.PreparedStatement;
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
@@ -11,10 +12,11 @@
         try {
             Connection con = DriverManager.getConnection("jdbc:mysql://localhost:3306/db");
 
-            String query = "SELECT *  FROM users WHERE username = '" +  request.getParameter("username") + "';";
-            Statement stmt = con.createStatement();
+            String query = "SELECT *  FROM users WHERE username = ?;";
+            PreparedStatement stmt = con.prepareStatement(query);
 
-            stmt.executeQuery(query);
+            stmt.setString(1, request.getParameter("username"));
+            stmt.executeQuery();
         } catch (Exception e) {
             throw new ServletException(e);
         }
 


Learn more and fine tune the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant