Skip to content

Add files via upload#209

Open
mobbeitan wants to merge 1 commit intomainfrom
mobbeitan-patch-1
Open

Add files via upload#209
mobbeitan wants to merge 1 commit intomainfrom
mobbeitan-patch-1

Conversation

@mobbeitan
Copy link
Owner

No description provided.

String query = "SELECT * FROM users WHERE username = '" + user + "';";
Statement stmt = con.createStatement();

stmt.executeQuery(query);
Copy link

@github-actions github-actions bot Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image SQL Injection fix is ready

Apply the following code change to fix SQL Injection issue detected by Snyk:

--- a/my naive db sample.java
+++ b/my naive db sample.java
@@ -1,3 +1,4 @@
+import java.sql.PreparedStatement;
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
@@ -12,10 +13,11 @@
             Connection con = DriverManager.getConnection("jdbc:mysql://localhost:3306/db");
             String user = request.getParameter("username");
 
-            String query = "SELECT * FROM users WHERE username = '" + user + "';";
-            Statement stmt = con.createStatement();
+            String query = "SELECT * FROM users WHERE username = ?;";
+            PreparedStatement stmt = con.prepareStatement(query);
 
-            stmt.executeQuery(query);
+            stmt.setString(1, user);
+            stmt.executeQuery();
         } catch (Exception e) {
             throw new ServletException(e);
         }
 


Learn more and fine tune the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant