Skip to content

fix atan264 for negative y and positive x #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamesGKent wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix atan264 for negative y and positive x #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2051eeb
fix atan264 for negative y and positive x
JamesGKent Feb 8, 2018
769cd0b
fix asin64 to return neg value with neg input
JamesGKent Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Math64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ f64 asin64(f64 z)

z=z/sqrt64(f64(1)-z*z);

if (z<0)
return -atan64(z);
return atan64(z);
}

Expand All @@ -172,7 +174,7 @@ f64 atan264(f64 y, f64 x)
if(x.isZero() && !y.isNegative()) return pio2;
if(y.isNegative() && x.isNegative()) return atan64(y/x)-pio2*f64(2);
if(x.isNegative()) return atan64(y/x)+pio2*f64(2); // y>=zero

if(y.isNegative() && !x.isNegative()) return -atan64(y/x);
return atan64(y/x); // x>zero
}

Expand Down