fix(ci): use always() on release job to break skip propagation#358
Merged
fix(ci): use always() on release job to break skip propagation#358
Conversation
…li-cross-os The cli-cross-os matrix job only runs on pull_request, so it is always skipped on push to main. GitHub's skip-taint propagation passes through ci-success (which uses always() for itself) and silently skips the release job before its if condition is ever evaluated. Adding always() breaks the transitive skip propagation, while needs.ci-success.result == 'success' preserves the CI-gate that always() would otherwise bypass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
releasejob inci.ymlwas being silently skipped on every push tomain— before itsifexpression was ever evaluated. This caused v0.5.11 to have no release despite CI passing.Root cause: skip-taint propagation through the
ci-successjob.if: always()onci-successallows it to run despite the skipped matrix dependency, but does not clear the skip signal for downstream jobs.releasehas a custom non-always()condition, so GitHub's scheduler skips it without evaluating the expression.Fix
Add
always()to thereleasejob to break the transitive skip propagation, while explicitly guarding withneeds.ci-success.result == 'success'to preserve the CI-gate thatalways()would otherwise bypass.Follow-up
After this merges, trigger
workflow_dispatchonrelease.ymlto backfill the missing v0.5.11 release.