-
Notifications
You must be signed in to change notification settings - Fork 33
Feat/clean exclude schema #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mmkal would you mind taking another look at this? excluding multiple schemas is really useful |
mmkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I like the separation of ported/parity tests from new features.
Minor request to make it fully non-breaking. I am a bit allergic to breaking changes, especially for projects like this where I'll be dipping in and out of it, and I want to minimise confusion over which version has which API.
mmkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Let's just make fully non breaking by using singular everywhere
|
Sorry for double comment, first wasn't showing up for me |
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
|
Thanks for following up on this PR. When can we expect a new release to land on npm? |
|
Today! Had some problems with the release script, but it's just the changelog generation that's going wrong, so I'll release manually today even if I can't fix. |
|
Release v0.6.0 addresses this. |
I removed my windows specific changes and installed the specific original migra version manually in order to make these changes
There is one failing test, but I diffed the 'differences' and according to diffchecker.com there's no difference, so I'm not sure if I'm reading it correctly or just blind or what but I want to see if the tests pass on CICD first
Also a small refactor, such that
FIXTURESNEW_FIXTURES