Skip to content

Conversation

@PhilipWee
Copy link
Contributor

I removed my windows specific changes and installed the specific original migra version manually in order to make these changes

There is one failing test, but I diffed the 'differences' and according to diffchecker.com there's no difference, so I'm not sure if I'm reading it correctly or just blind or what but I want to see if the tests pass on CICD first

Also a small refactor, such that

  • python parity fixtures are in FIXTURES
  • new feature fixtures are in NEW_FIXTURES
 set
    check_function_bodies = off;

  CREATE
- OR REPLACE FUNCTION public.newfunc (i integer, t text []) RETURNS TABLE (a text, c integer) LANGUAGE plpgsql STABLE STRICT AS $function$
-  declare
-         BEGIN
-                 select 'no', 1;
-         END;
-
+ OR REPLACE FUNCTION public.newfunc (i integer, t text []) RETURNS TABLE (a text, c integer) LANGUAGE plpgsql STABLE STRICT AS $function$
+  declare
+         BEGIN
+                 select 'no', 1;
+         END;
+
  $function$;

  CREATE
- OR REPLACE FUNCTION public.changed (i integer, t text []) RETURNS TABLE (a text, c integer) LANGUAGE plpgsql STRICT SECURITY DEFINER AS $function$    
-  declare
-         BEGIN
-                 select 'no', 1;
-         END;
-
+ OR REPLACE FUNCTION public.changed (i integer, t text []) RETURNS TABLE (a text, c integer) LANGUAGE plpgsql STRICT SECURITY DEFINER AS $function$    
+  declare
+         BEGIN
+                 select 'no', 1;
+         END;
+
  $function$;
  create materialized view "public"."matvvv" as
  SELECT
    2 AS a;

@vercel
Copy link

vercel bot commented Jun 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pgkit 🛑 Canceled (Inspect) Jul 30, 2025 6:03am

@sweatybridge
Copy link
Contributor

@mmkal would you mind taking another look at this? excluding multiple schemas is really useful

Copy link
Owner

@mmkal mmkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I like the separation of ported/parity tests from new features.

Minor request to make it fully non-breaking. I am a bit allergic to breaking changes, especially for projects like this where I'll be dipping in and out of it, and I want to minimise confusion over which version has which API.

Copy link
Owner

@mmkal mmkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Let's just make fully non breaking by using singular everywhere

@mmkal
Copy link
Owner

mmkal commented Jul 29, 2025

Sorry for double comment, first wasn't showing up for me

PhilipWee and others added 7 commits July 30, 2025 14:00
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Co-authored-by: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
@mmkal mmkal merged commit cf1d102 into mmkal:main Jul 30, 2025
4 checks passed
@sweatybridge
Copy link
Contributor

Thanks for following up on this PR. When can we expect a new release to land on npm?

@mmkal
Copy link
Owner

mmkal commented Aug 5, 2025

Today! Had some problems with the release script, but it's just the changelog generation that's going wrong, so I'll release manually today even if I can't fix.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Release v0.6.0 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants