Fix: GenerateSharedVerticesIndexListSlow() bug #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: Uninitialized variable index2rec
Problem: The variable index2rec was being used without being properly assigned in the inner loop, leading to undefined behavior.
Root Cause: In the nested loop that searches for matching vertices, index2rec was declared but never assigned the value of index2 before the comparison logic.
Fix: Added the missing assignment index2rec = index2; in the inner loop.
2: Unused variable iNumUniqueVerts
Problem: The variable iNumUniqueVerts was declared and incremented but never actually used, causing compilation warnings and dead code.
Fix: Removed the unused variable declaration and its increment operation.