Remove global config state from csconfig package

[Copilot]

Removes globalConfig variable and GetConfig() function from pkg/csconfig. Config is now passed explicitly through function parameters.

Changes

csconfig package

• Removed globalConfig variable and GetConfig() function
• Removed assignment in NewConfig()

apiserver

• GetUsageMetrics() now uses existing a.consoleConfig field instead of csconfig.GetConfig()

acquisition package

• Added clientConfig *csconfig.LocalApiClientCfg parameter to:
  • DataSourceConfigure()
  • LoadAcquisitionFromDSN()
  • ParseSourceConfig()
  • sourcesFromFile()
  • LoadAcquisitionFromFiles()

cmd/crowdsec

• Extracts clientConfig once and passes through acquisition call chain

tests

• Updated test signatures with new parameter
• Added mock clientConfig for appsec datasource tests

Example

Before:

// In acquisition code
cConfig := csconfig.GetConfig()
lapiClientAware.SetClientConfig(cConfig.API.Client)

After:

// Passed explicitly
func DataSourceConfigure(..., clientConfig *csconfig.LocalApiClientCfg) {
    if lapiClientAware, ok := dataSrc.(types.LAPIClientAware); ok {
        if clientConfig != nil {
            lapiClientAware.SetClientConfig(clientConfig)
        }
    }
}

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
pkg/acquisition/config_test.go	20% smaller
pkg/acquisition/acquisition.go	12% smaller
pkg/apiserver/apic_metrics.go	2% smaller
.gitignore	Unsupported file format
cmd/crowdsec/main.go	0% smaller
pkg/acquisition/acquisition_test.go	0% smaller
pkg/csconfig/config.go	0% smaller