Draft
Conversation
These are the remaining changes that are needed to get the Gries & Schneider tests working without conversions done inside the Expression() constructor. In the benchmarking branch, we'll modify this further so we can get an additional long-running benchmark test.
* NIntegrate[] no longer requires scipy. * There were a number of small changes/fixes involving NIntegrate. * NIntegrate tests have been expanded.
Revise Nintegrate to allow scipy to be optional
Also adjust some items->elements and try to add type annotations. A FIXME was noted because in a branch where things don't look quite right.
…sions-3 More expression conversions 3
And the usual imports and class variable ordering, and docstring tagging canonicalization
…sions-4 72 more conversions to go
rocky's review
d41fd83 to
f9ee474
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.