Skip to content

Add UMD support#11

Open
artursmirnov wants to merge 1 commit intommalecki:masterfrom
artursmirnov:master
Open

Add UMD support#11
artursmirnov wants to merge 1 commit intommalecki:masterfrom
artursmirnov:master

Conversation

@artursmirnov
Copy link
Copy Markdown

This PR introduces a UMD support. I wrapped the ansiparse function to a closure and exposed it as common-js, es-export and amd module.

@abitrolly
Copy link
Copy Markdown

Ok. This UMD is some kind of JavaScript boilerplate to allow different packagers in Node ecosystem understand the module. https://github.com/umdjs/umd

@mmalecki the whole Travis CI depends on your code. )

https://travis-ci.community/t/ansi-logs-missing-colors-and-formatting-problems/9489/2

Do you plan to maintain the lib, or maybe recommend the alternative?

@mmalecki
Copy link
Copy Markdown
Owner

mmalecki commented Aug 1, 2020

👋 @abitrolly. Taking a quick look at this PR, and the referenced Travis Community thread - it would appear that they're unrelated?

I'd be happy to add the colors we're missing here, but I believe that producing outputs suited to different module systems should happen during the build process. @artursmirnov I see that travis-web now uses your fork of this library, so it doesn't look like this PR is blocking development there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants