Used polymer modulizer to convert the element to Polymer 3 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it was possible that percentual heights were not propagated correctly as the saw-div did not have the same height as the resize-aware element. Also fixed the CSS style which refered to the element saw but was probably meant for the div with the id "saw"
Owner
|
Thank you for this PR! I expect to complete testing, merging and publishing this on 6/2. |
Owner
|
Looking good, though the demo is not running ... |
Author
|
Some import paths were broken while modulizing, I guess this applies to the scripts in the demo as well. I will look into it, when I find some time. |
Owner
|
I've decided to leave this element at Polymer 2.0 and release plastic-resize-aware for Polymer 3.0, which is needed for the next version of plastic-map-info and a work project in progress.
|
Author
|
As you already released your Polymer 3 version quite some time ago, I'll just close here. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted the element to Polymer 3, using the polymer modulizer. Fortunately, it went through without any problems.
This PR includes #7 as I used the modulizer on my fork.
You would need to change the name of the npm package to use it.