Skip to content

Conversation

@ShriyaRishab
Copy link
Contributor

@ShriyaRishab ShriyaRishab commented Dec 16, 2025

Changes made based on discussion in Training WG on 12.11.2025 as requested by Mangoboost

Signed-off-by: ShriyaRishab <spalsamudram@nvidia.com>
@ShriyaRishab ShriyaRishab requested a review from a team as a code owner December 16, 2025 22:24
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@ShriyaRishab
Copy link
Contributor Author

@mlcommons/wg-inference - approved by training, is inference ok with this?

Girishg17

This comment was marked as outdated.

@hanyunfan
Copy link
Contributor

@ShriyaRishab Let me check with MangoBoost to see if they can discuss this in the next WG meeting and take questions.

@hanyunfan
Copy link
Contributor

Mangoboost will present this and we will discuss in next WG meeting (2/27)

@swasson488
Copy link
Contributor

swasson488 commented Jan 27, 2026

I agree with the intent of the proposed idea, but the current wording doesn't make sense in a context where the joint submitters don't also submit individually, which could happen. Also, a little more clarification might help.

I propose the following wording instead:


For peer review assignments, each company involved in a joint submission shall be treated as a separate submitting organization. For example, if Supermicro and MangBoost submit jointly, both Supermicro and Mangoboost will be treated as individual submitters. Each one will be assigned a peer organization's submission to review, and a peer will be assigned to review each organization's submissions. By this arrangement, a joint submission involving two submitting organizations will be reviewed by two peer organizations, not just one.

Also, a submitter involved in a joint submission shall not be assigned to review its partner submitter's work due to the obvious conflict of interest.

@ShriyaRishab
Copy link
Contributor Author

@swasson488 your wording makes sense, updated it.

@swasson488
Copy link
Contributor

@swasson488 your wording makes sense, updated it.

I made one edit to my suggestion in the comment above: "reviewered" -> "reviewed"

You may want to edit the new proposed text with that fix.

@hanyunfan
Copy link
Contributor

@swasson488 Just checking on the next step. Do you think we need to discuss this next week in WG again, or can we approve it here now?

@swasson488
Copy link
Contributor

@swasson488 Just checking on the next step. Do you think we need to discuss this next week in WG again, or can we approve it here now?

What do you think? There was little discussion outside of us in the WG meeting, so this seems uncontroversial. But I'm happy to discuss again if we want to be sure we have consensus. There is no big rush right now.

@hanyunfan
Copy link
Contributor

n the WG meeting, so this seems uncontroversial. But I'm happy to discuss again if we want to be sure we have consensus. There is no big rush right

ok, let's quickly talk about it again in WG next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants