Open
Conversation
So we can use const fields in a mutable struct
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 83.16% 83.63% +0.47%
==========================================
Files 13 13
Lines 588 666 +78
==========================================
+ Hits 489 557 +68
- Misses 99 109 +10 ☔ View full report in Codecov by Sentry. |
To ensure it re-exports OptimizationBase
Member
Author
|
The basic functionality is here. All that remains is to remove now-unused methods and their corresponding tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #213.
Most of the changes are a clean-up and refactor of internal functions and types related to reconstruction of a compact representation of L-BFGS's inverse Hessian approximation from pairs of positions and gradients. All changes are internal.
This PR also bumps the Julia lower bound to v1.8, which should not be a problem now that v1.10 is the LTS.