[Fix] Add bool dtype support to IntImm and MakeConstScalar #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLC local ci setup. Also CI for Windows and macOS building, which may take 90-100 mins. Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
- Revert "[CMake][MSVC] Disable permissive mode for MSVC builds (#16343)" - Skip MSC tests - Disable NNPack and TFLite - Tweak CMAKE_CUDA_ARCHITECTURES
Contributor
|
this should be fixed upstream already, @MasterJH5574 @tlopex perhaps we should do a bump here |
Member
|
I just rebased the main branch to sync with the latest apache/tvm. The nightly build wheel will be ready in about 24hr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After TVM PR apache/tvm#18453 introduced explicit bool dtype aligned with DLPack, boolean literals assigned to bool-typed buffers fail with:
This patch adds bool support to:
IntImmconstructor validation (src/ir/expr.cc)MakeConstScalartemplate (include/tvm/tir/op.h)Related Issues
Note
TVM has a WIP branch with a similar fix: https://github.com/apache/tvm/tree/tvm-ffi-bool