handle delete when message id bytes #23
Conversation
|
@mlasevich ☝️ 😃 |
|
My apologies, will take a look |
mlasevich
left a comment
mlasevich
left a comment
There was a problem hiding this comment.
It pays for me to replicate the issue locally to understand it better. Now that I look at it. its pretty bad. Thanks for the contribution.
| if int(result[0]) == 1 and int(result[1]) > 0: | ||
| # 1 key deleted from zset | ||
| # 3 keys deleted from hash (message itself, receive count, first receive field) | ||
| if int(result[0]) == 1 and int(result[1]) == 3: |
There was a problem hiding this comment.
Is there a scenario where result[1] > 0 but not 3?
There was a problem hiding this comment.
I don't think so, unless the number of keys stored per message in the hash changes. From what I could tell, the message, receive count, and first receive are always there, so if there are not deleted then there would be some sort of problem. That was my thought process around this.
There was a problem hiding this comment.
makes sense.... BTW, it is out as v0.6.1 🤞🏻
|
|
||
| # decode to string when provided as bytes | ||
| if isinstance(message_id, bytes): | ||
| message_id = message_id.decode('utf-8') |
There was a problem hiding this comment.
to avoid issues with tx.zrem() we may want to adjust the message id specifically for generated rc/fr keys - but it seems to work fine as-is
2 participants
Decode message_id to
strwhen it is provided asbytes.Closes #17