Skip to content

load metallib not only as resource but in root of a bundle #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gin66 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

load metallib not only as resource but in root of a bundle #2885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions mlx/backend/metal/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ MTL::Library* try_load_bundle(
MTL::Device* device,
NS::URL* url,
const std::string& lib_name) {
std::string path =
std::string(url->fileSystemRepresentation()) +
"/" + lib_name + ".metallib";

auto [lib, error] = load_library_from_path(device, path.c_str());
if (lib) {
return lib;
}

// url contains already the resource path. Why to rebuild it here again ?
std::string bundle_path = std::string(url->fileSystemRepresentation()) + "/" +
SWIFTPM_BUNDLE + ".bundle";
auto bundle = NS::Bundle::alloc()->init(
Expand Down Expand Up @@ -115,6 +125,11 @@ std::pair<MTL::Library*, NS::Error*> load_swiftpm_library(
if (library != nullptr) {
return {library, nullptr};
}
// MetalCompilerPlugin does not generate a resource, but puts it into the bundle
library = try_load_bundle(device, bundle->bundleURL(), lib_name);
if (library != nullptr) {
return {library, nullptr};
}
}
// if SWIFTPM_BUNDLE is a framework identifier, try loading from that
auto frameworks = NS::Bundle::allFrameworks();
Expand Down