llama inference with tensor parallelism#1403
Open
stefpi wants to merge 7 commits intoml-explore:mainfrom
Open
Conversation
stefpi
changed the title
awni
reviewed
Jan 28, 2026
awni
reviewed
Jan 28, 2026
Comment on lines
+372
to
+375
| class_predicate = ( | ||
| lambda p, m: isinstance(m, (nn.Linear, nn.Embedding)) | ||
| and f"{p}.scales" in weights | ||
| ) |
Member
There was a problem hiding this comment.
I'm curious about that change? Was it needed for a specific model?
Author
There was a problem hiding this comment.
I was having trouble with running quantized models, specifically Llama-2-4bit, and I saw this being used in the gguf llm example for quantized models.
Co-authored-by: Awni Hannun <awni.hannun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #2973 on mlx repo.
mlx.launchon 2 or more devices