consistency across converters #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de class to create nodes for miRNAs. Will result in all miRNA nodes having a Mirbase ID as identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to make the different conversion scripts more consistent. Biggest change is that they all use the MiRNANode class now to add the miRNA to the network. This may result in different output than the original code: 1) all nodes now have the mature mirbas ID as identifier (before it was sometimes the hsa-mir-* form, other times the mirbase ID), 2) nodes that could not be mapped to mirbase are skipped with a warning in the log. Please see if this is OK for CyTargetLinker - i.e. if it doesn't break anything :).