Allow user to run post-termination tasks via callback #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a feature which allows the user to provide a Proc callback to the VagrantPlugins::AWS::Config class. If set, then immediately after the instance is terminated (in the destroy lifecycle), the callback will get called. This facilitates use-cases where the user needs to do post-destroy cleanup tasks, such as removing associated Route53 records or anything else.
mkubenka
requested changes
Oct 10, 2017
Owner
mkubenka
left a comment
mkubenka
left a comment
There was a problem hiding this comment.
Please update config spec test with new option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a feature which allows the user to provide a Proc
callback to the VagrantPlugins::AWS::Config class. If set, then
immediately after the instance is terminated (in the destroy lifecycle),
the callback will get called. This facilitates use-cases where the user
needs to do post-terminate cleanup work, such as removing associated
Route53 records or anything else.